[webkit-reviews] review requested: [Bug 189198] [Curl][WebKitLegacy] Stop sending credential embedded in the url via XHR. : [Attachment 348675] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 31 14:50:41 PDT 2018


Basuke Suzuki <Basuke.Suzuki at sony.com> has asked  for review:
Bug 189198: [Curl][WebKitLegacy] Stop sending credential embedded in the url
via XHR.
https://bugs.webkit.org/show_bug.cgi?id=189198

Attachment 348675: PATCH

https://bugs.webkit.org/attachment.cgi?id=348675&action=review




--- Comment #2 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Comment on attachment 348675
  --> https://bugs.webkit.org/attachment.cgi?id=348675
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=348675&action=review

> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:-385
> -    auto localRequest = request;

Stop using passed request directly. Use resourceHandleInternal's firstRequest,
which is already stripped.


More information about the webkit-reviews mailing list