[webkit-reviews] review granted: [Bug 183705] [ WK2 ] http/tests/workers/service/client-*-page-cache.html LayoutTests are flaky : [Attachment 348671] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183705: [ WK2 ] http/tests/workers/service/client-*-page-cache.html
LayoutTests are flaky
https://bugs.webkit.org/show_bug.cgi?id=183705

Attachment 348671: Patch

https://bugs.webkit.org/attachment.cgi?id=348671&action=review




--- Comment #28 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 348671
  --> https://bugs.webkit.org/attachment.cgi?id=348671
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348671&action=review

> Source/WebCore/testing/Internals.cpp:2331
> +String Internals::serviceWorkerClientIdentifier(Document& document) const

const Document& maybe?

> LayoutTests/ChangeLog:10
> +	   identifiers to see if they are present or not.

Were these tests testable in a regular browser before?
Would it make sense to use internals API if available and rely on client count
otherwise?

Looking further for some tests, for controlled/uncontrolled clients, it makes
sense to use identifiers.