[webkit-reviews] review granted: [Bug 189183] slotchange-event-bubbling.html fails in Chrome & Firefox : [Attachment 348600] Fixes the test

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 189183: slotchange-event-bubbling.html fails in Chrome & Firefox
https://bugs.webkit.org/show_bug.cgi?id=189183

Attachment 348600: Fixes the test

https://bugs.webkit.org/attachment.cgi?id=348600&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 348600
  --> https://bugs.webkit.org/attachment.cgi?id=348600
Fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=348600&action=review

> LayoutTests/ChangeLog:8
> +	   slotchange event is supposed to fire when a slot element is inserted
and there are assinged nodes.

Typo: assinged

> LayoutTests/ChangeLog:10
> +	   Firefox and Chrome implements this behavior and fails this test
since the test doesn't let microstask

Typo: implements -> implement / fails -> fail

> LayoutTests/ChangeLog:13
> +	   Fixed the test by manually waiting for the current microtask queue
is emptied after constructing

is emptied -> to be emptied?