[webkit-reviews] review denied: [Bug 189178] Expose -apple-system-container-border color to internal web views : [Attachment 348575] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied James Savage
<james.savage at apple.com>'s request for review:
Bug 189178: Expose -apple-system-container-border color to internal web views
https://bugs.webkit.org/show_bug.cgi?id=189178

Attachment 348575: Patch

https://bugs.webkit.org/attachment.cgi?id=348575&action=review




--- Comment #9 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 348575
  --> https://bugs.webkit.org/attachment.cgi?id=348575
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348575&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:680
> +	   case CSSValueAppleSystemContainerBorder:
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
> +	       return systemAppearanceColor(cache.systemContainerBorderColor,
@selector(containerBorderColor));
> +#else
> +	       return 0xFFC5C5C5;
> +#endif

You only need to handle it here and use the special
cache.systemContainerBorderColor if this color is different based on accent
color. I don't think it is, so yo can simplify this patch by handling it with
the other system colors further down in this file.