[webkit-reviews] review granted: [Bug 189199] Assertion hit in ~CompletionHandler() from ~WebFrame() : [Attachment 348649] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 189199: Assertion hit in ~CompletionHandler() from ~WebFrame()
https://bugs.webkit.org/show_bug.cgi?id=189199

Attachment 348649: Patch

https://bugs.webkit.org/attachment.cgi?id=348649&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 348649
  --> https://bugs.webkit.org/attachment.cgi?id=348649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348649&action=review

> Source/WebCore/loader/EmptyClients.cpp:461
> +void EmptyFrameLoaderClient::dispatchWillSubmitForm(FormState&,
CompletionHandler<void(void)>&& completionHandler)

s/void(void)/void()/ here and below?

> Source/WebKit/WebProcess/WebPage/WebFrame.cpp:252
> +	   completionHandler();

Should we be safe here and move m_willSubmitFormCompletionHandlers.values in a
local variable as well.
Then no need to clear it anymore below.