[webkit-reviews] review granted: [Bug 189193] [LFC] Add margin box verification back now that Display::Box has non-computed horizontal margin. : [Attachment 348641] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 189193: [LFC] Add margin box verification back now that Display::Box has
non-computed horizontal margin.
https://bugs.webkit.org/show_bug.cgi?id=189193

Attachment 348641: Patch

https://bugs.webkit.org/attachment.cgi?id=348641&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 348641
  --> https://bugs.webkit.org/attachment.cgi?id=348641
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348641&action=review

> Source/WebCore/layout/Verification.cpp:132
> +	       borderBox.top() - displayBox.nonCollapsedMarginTop()
> +	       , borderBox.left() - displayBox.nonComputedMarginLeft()
> +	       , displayBox.nonComputedMarginLeft() + borderBox.width() +
displayBox.nonComputedMarginRight()
> +	       , displayBox.nonCollapsedMarginTop() + borderBox.height() +
displayBox.nonCollapsedMarginBottom() 

Those commas would look better at the end of the line.