[webkit-reviews] review denied: [Bug 189190] REGRESSION(r235398) ASSERTION failure !m_client.didFinishDocumentLoadForFrame with external SDK build : [Attachment 348636] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 31 10:19:56 PDT 2018


Alex Christensen <achristensen at apple.com> has denied Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 189190: REGRESSION(r235398) ASSERTION failure
!m_client.didFinishDocumentLoadForFrame with external SDK build
https://bugs.webkit.org/show_bug.cgi?id=189190

Attachment 348636: Patch

https://bugs.webkit.org/attachment.cgi?id=348636&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 348636
  --> https://bugs.webkit.org/attachment.cgi?id=348636
Patch

I mean, we would want to not assert if you're on Mojave or before just to work
with system safari.


More information about the webkit-reviews mailing list