[webkit-reviews] review granted: [Bug 189171] Introduce LibWebRTC backends for sender and receiver : [Attachment 348603] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 31 05:35:19 PDT 2018
Alejandro G. Castro <alex at igalia.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 189171: Introduce LibWebRTC backends for sender and receiver
https://bugs.webkit.org/show_bug.cgi?id=189171
Attachment 348603: Patch
https://bugs.webkit.org/attachment.cgi?id=348603&action=review
--- Comment #14 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 348603
--> https://bugs.webkit.org/attachment.cgi?id=348603
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=348603&action=review
LGTM, let's do it.
> Source/WebCore/Modules/mediastream/RTCRtpReceiverBackend.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.
Probably you want to add Apple for this new file.
> Source/WebCore/Modules/mediastream/RTCRtpReceiverBackend.h:16
> + * 3. Neither the name of Ericsson nor the names of its contributors
> + * may be used to endorse or promote products derived from this
> + * software without specific prior written permission.
And remove this.
More information about the webkit-reviews
mailing list