[webkit-reviews] review granted: [Bug 189175] [WHLSL] Fix array indexing behavior : [Attachment 348568] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Thomas Denney
<tdenney at apple.com>'s request for review:
Bug 189175: [WHLSL] Fix array indexing behavior
https://bugs.webkit.org/show_bug.cgi?id=189175

Attachment 348568: Patch

https://bugs.webkit.org/attachment.cgi?id=348568&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 348568
  --> https://bugs.webkit.org/attachment.cgi?id=348568
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348568&action=review

> Tools/ChangeLog:7
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

Need some description

> Tools/WebGPUShadingLanguageRI/Parse.js:266
> +	       // token is updated each iteration, so constructors must use the
token associated with their iteration.
> +	       const tokenCopy = token;

can you fix this by saying "while (let token = ...)"?