[webkit-reviews] review granted: [Bug 189119] Remove redundant inline text boxes for empty combined text : [Attachment 348510] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Daniel Bates <dbates at webkit.org>'s request
for review:
Bug 189119: Remove redundant inline text boxes for empty combined text
https://bugs.webkit.org/show_bug.cgi?id=189119

Attachment 348510: Patch

https://bugs.webkit.org/attachment.cgi?id=348510&action=review




--- Comment #8 from zalan <zalan at apple.com> ---
Comment on attachment 348510
  --> https://bugs.webkit.org/attachment.cgi?id=348510
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348510&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:79
> +bool InlineTextBox::isEmpty() const

In some cases we use "empty" in the context of something is _visually_ empty.
I'd rather try the term hasTextContent() or something along those lines.