[webkit-reviews] review granted: [Bug 189170] REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share : [Attachment 348537] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 13:40:44 PDT 2018


Tim Horton <thorton at apple.com> has granted Olivia Barnett
<obarnett at apple.com>'s request for review:
Bug 189170: REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html
crashes under Navigator::share
https://bugs.webkit.org/show_bug.cgi?id=189170

Attachment 348537: Patch

https://bugs.webkit.org/attachment.cgi?id=348537&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 348537
  --> https://bugs.webkit.org/attachment.cgi?id=348537
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348537&action=review

> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

Get this outta here. Maybe "No new tests; fixing a failing existing test."


More information about the webkit-reviews mailing list