[webkit-reviews] review granted: [Bug 158911] InlineAccess should do StringLength : [Attachment 348460] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 30 11:21:42 PDT 2018
Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 158911: InlineAccess should do StringLength
https://bugs.webkit.org/show_bug.cgi?id=158911
Attachment 348460: patch
https://bugs.webkit.org/attachment.cgi?id=348460&action=review
--- Comment #9 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 348460
--> https://bugs.webkit.org/attachment.cgi?id=348460
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=348460&action=review
r=me
> Source/JavaScriptCore/bytecode/InlineAccess.cpp:173
> + GPRReg base = stubInfo.baseGPR();
Nice improvement.
> Source/JavaScriptCore/bytecode/StructureStubInfo.h:201
> #endif
I think we can use GPRReg directly here (instead of int8_t), since they are
`enum : int8_t` now!
More information about the webkit-reviews
mailing list