[webkit-reviews] review granted: [Bug 188952] output of toString() of Generator is wrong : [Attachment 348511] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 11:12:02 PDT 2018


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 188952: output of toString() of Generator is wrong
https://bugs.webkit.org/show_bug.cgi?id=188952

Attachment 348511: Patch

https://bugs.webkit.org/attachment.cgi?id=348511&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 348511
  --> https://bugs.webkit.org/attachment.cgi?id=348511
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348511&action=review

r=me

> Source/JavaScriptCore/runtime/FunctionPrototype.cpp:136
> +	   case SourceParseMode::AsyncGeneratorWrapperMethodMode:

Shouldn't this async generator method be "async* " since that's the syntax?


More information about the webkit-reviews mailing list