[webkit-reviews] review granted: [Bug 189088] Make it possible to mark tests as leaks in TestExpectations : [Attachment 348435] Patch

[bugzilla-daemon at webkit.org]

Jon Lee <jonlee at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 189088: Make it possible to mark tests as leaks in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=189088

Attachment 348435: Patch

https://bugs.webkit.org/attachment.cgi?id=348435&action=review




--- Comment #10 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 348435
  --> https://bugs.webkit.org/attachment.cgi?id=348435
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348435&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:-248
> -	   'Leak': 'LEAK',

There are enough here that maybe the list should just be alphabetized...?

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:868
>	       expected_results.add(PASS)

Not part of your patch, but it seems like this is wrong.

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:136
>	   self.assertEqual(TestExpectations.remove_pixel_failures(set([PASS,
IMAGE, CRASH])), set([PASS, CRASH]))

Maybe add some test cases with LEAK here?