[webkit-reviews] review granted: [Bug 189146] Add assignedElements to HTMLSlotElement : [Attachment 348485] Adds the method

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 189146: Add assignedElements to HTMLSlotElement
https://bugs.webkit.org/show_bug.cgi?id=189146

Attachment 348485: Adds the method

https://bugs.webkit.org/attachment.cgi?id=348485&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 348485
  --> https://bugs.webkit.org/attachment.cgi?id=348485
Adds the method

View in context: https://bugs.webkit.org/attachment.cgi?id=348485&action=review

> Source/WebCore/html/HTMLSlotElement.h:43
>      Vector<Node*> assignedNodes(const AssignedNodesOptions&) const;
> +    Vector<Ref<Element>> assignedElements(const AssignedNodesOptions&)
const;

Why does assignedNodes return Node* instead of Ref<Node>? Why not make the two
consistent?