[webkit-reviews] review granted: [Bug 189000] Mock video devices should only support discrete sizes : [Attachment 348462] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 189000: Mock video devices should only support discrete sizes
https://bugs.webkit.org/show_bug.cgi?id=189000

Attachment 348462: Patch

https://bugs.webkit.org/attachment.cgi?id=348462&action=review




--- Comment #14 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 348462
  --> https://bugs.webkit.org/attachment.cgi?id=348462
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348462&action=review

> Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:49
> +void RealtimeVideoSource::startProducingData()

Maybe we should rename it to something like prepareToProduceData?
Subclasses would call that helper method from startProducingData.