[webkit-reviews] review granted: [Bug 189130] Avoid code duplication in ResourceLoadStatisticsMemoryStore::processStatisticsAndDataRecords() : [Attachment 348449] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 189130: Avoid code duplication in
ResourceLoadStatisticsMemoryStore::processStatisticsAndDataRecords()
https://bugs.webkit.org/show_bug.cgi?id=189130

Attachment 348449: Patch

https://bugs.webkit.org/attachment.cgi?id=348449&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 348449
  --> https://bugs.webkit.org/attachment.cgi?id=348449
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348449&action=review

> Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp:358
> +	       return;

I guess there is a small behavior change if
m_parameters.shouldNotifyPagesWhenDataRecordsWereScanned value is updated
between the time removeDataRecords is called and the lambda is executed.