[webkit-reviews] review granted: [Bug 189083] [WHLSL] Ensure that isLValue is copied by the rewriter : [Attachment 348405] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Thomas Denney
<tdenney at apple.com>'s request for review:
Bug 189083: [WHLSL] Ensure that isLValue is copied by the rewriter
https://bugs.webkit.org/show_bug.cgi?id=189083

Attachment 348405: Patch

https://bugs.webkit.org/attachment.cgi?id=348405&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 348405
  --> https://bugs.webkit.org/attachment.cgi?id=348405
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348405&action=review

> Tools/WebGPUShadingLanguageRI/Test.js:275
> +    function ternaryExpressionIsLValue(node)
> +    {
> +	   let isLValue;
> +	   class TernaryExpressionVisitor extends Visitor {
> +	       visitTernaryExpression(node)
> +	       {
> +		   isLValue = node.isLValue;
> +	       }
> +	   }
> +	   node.visit(new TernaryExpressionVisitor());
> +	   return isLValue;
> +    }

This is an unfortunate test, because it doesn't describe anything user-visible.
Are you sure there's no way this bug is visible without using compiler
internals?