[webkit-reviews] review granted: [Bug 189055] [IntersectionObserver] Implement intersection logic for the same-document implicit root case : [Attachment 348336] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 189055: [IntersectionObserver]  Implement intersection logic for the
same-document implicit root case
https://bugs.webkit.org/show_bug.cgi?id=189055

Attachment 348336: Patch

https://bugs.webkit.org/attachment.cgi?id=348336&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 348336
  --> https://bugs.webkit.org/attachment.cgi?id=348336
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348336&action=review

> Source/WebCore/dom/Document.cpp:7465
> +	   if (!rootRenderer->isContainingBlockAncestorFor(*targetRenderer))

Shame we have to do an ancestor walk here.