[webkit-reviews] review granted: [Bug 189037] Add error information to help debug test failure in WKNavigation.ProcessCrashDuringCallback : [Attachment 348320] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 189037: Add error information to help debug test failure in
WKNavigation.ProcessCrashDuringCallback
https://bugs.webkit.org/show_bug.cgi?id=189037

Attachment 348320: Patch

https://bugs.webkit.org/attachment.cgi?id=348320&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 348320
  --> https://bugs.webkit.org/attachment.cgi?id=348320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348320&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:4576
> +	       NSError* callbackError = [NSError errorWithDomain:WKErrorDomain
code:static_cast<int>(error) userInfo:nil];

FYI, we use star on right size for NS types. But in this case, I'd rather we
drop this local variable completely:
completionHandlerBlock(nil, [NSError errorWithDomain:WKErrorDomain
code:static_cast<int>(error) userInfo:nil]);

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:4591
> +	       NSError* callbackError = [NSError errorWithDomain:WKErrorDomain
code:static_cast<int>(error) userInfo:nil];

ditto.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:4605
> +	       NSError* callbackError = [NSError errorWithDomain:WKErrorDomain
code:static_cast<int>(error) userInfo:nil];

ditto.