[webkit-reviews] review denied: [Bug 188978] [WinCairo] Add CryptoDigiestOpenSSL : [Attachment 348235] Patch take2

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Yoshiaki Jitsukawa
<yoshiaki.jitsukawa at sony.com>'s request for review:
Bug 188978: [WinCairo] Add CryptoDigiestOpenSSL
https://bugs.webkit.org/show_bug.cgi?id=188978

Attachment 348235: Patch take2

https://bugs.webkit.org/attachment.cgi?id=348235&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 348235
  --> https://bugs.webkit.org/attachment.cgi?id=348235
Patch take2

View in context: https://bugs.webkit.org/attachment.cgi?id=348235&action=review

> Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:81
> +    case CryptoDigest::Algorithm::SHA_1:
> +	   delete toSHA1Context(m_context.get());
> +	   return;
> +    case CryptoDigest::Algorithm::SHA_224:
> +	   delete toSHA224Context(m_context.get());
> +	   return;

This is what a virtual destructor is for.

> Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:96
> +    std::unique_ptr<CryptoDigest> digest(new CryptoDigest);

This is also what make_unique is for.