[webkit-reviews] review granted: [Bug 188927] [LayoutTests] results.html shows "no expected results" for text diff failures : [Attachment 348219] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 188927: [LayoutTests] results.html shows "no expected results" for text
diff failures
https://bugs.webkit.org/show_bug.cgi?id=188927

Attachment 348219: Patch

https://bugs.webkit.org/attachment.cgi?id=348219&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 348219
  --> https://bugs.webkit.org/attachment.cgi?id=348219
Patch

I think that the code is structured quite confusingly, as function names don't
make it clear which ones handle results from retries (like "TEXT MISSING" or
"TEXT IMAGE"), and which don't.

Given test coverage, it seems OK for now.