[webkit-reviews] review granted: [Bug 189007] [IntersectionObserver] Schedule intersection observation updates : [Attachment 348204] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 189007: [IntersectionObserver] Schedule intersection observation updates
https://bugs.webkit.org/show_bug.cgi?id=189007

Attachment 348204: Patch

https://bugs.webkit.org/attachment.cgi?id=348204&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 348204
  --> https://bugs.webkit.org/attachment.cgi?id=348204
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348204&action=review

> Source/WebCore/ChangeLog:11
> +	   2) FrameView::viewportContentsChanged -- this covers changes to
layout and
> +	      to scroll positions.

What about scrolls in ancestor frames of the frames containing observers, or
observers in the root document on elements nested in subframes, and scrolls of
intermediate frames?

> Source/WebCore/dom/Document.cpp:7575
> +    m_intersectionObservationUpdateTimer.startOneShot(0_s);

Maybe add a comment that this timer should really be something that fits into
HTMLEventLoop (once we have that).

> Source/WebCore/dom/Document.h:1782
> +    bool m_needsIntersectionObservationUpdate { false };

Can you pack that bool with other bools please?