[webkit-reviews] review granted: [Bug 188903] [Cocoa] Exception (fileType 'dyn.agq8u' is not a valid UTI) raised when dragging an attachment whose file wrapper is a directory : [Attachment 348155] Rebase on trunk

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 188903: [Cocoa] Exception (fileType 'dyn.agq8u' is not a valid UTI) raised
when dragging an attachment whose file wrapper is a directory
https://bugs.webkit.org/show_bug.cgi?id=188903

Attachment 348155: Rebase on trunk

https://bugs.webkit.org/attachment.cgi?id=348155&action=review




--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 348155
  --> https://bugs.webkit.org/attachment.cgi?id=348155
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=348155&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:385
> -    [self setFileWrapper:fileWrapper.get() contentType:newContentType
completion:^(NSError *error) {
> +    [self setFileWrapper:(__bridge NSFileWrapper *)fileWrapper.get()
contentType:newContentType completion:^(NSError *error) {

What is going on with all the 🌉? Other than that, r+, but please get rid of
bridges for casts not between CF and NS objects.