[webkit-reviews] review granted: [Bug 188959] Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering : [Attachment 348115] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 188959: Web Inspector: REGRESSION: virtualized TreeOutline is empty when
filtering
https://bugs.webkit.org/show_bug.cgi?id=188959

Attachment 348115: Patch

https://bugs.webkit.org/attachment.cgi?id=348115&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 348115
  --> https://bugs.webkit.org/attachment.cgi?id=348115
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348115&action=review

r=me but please make it more readable

> Source/WebInspectorUI/UserInterface/Views/TreeElement.js:169
> +	       this.treeOutline.soon.updateVirtualizedElements(!this._hidden &&
this.selected ? this : null);

Pls extract this condition out so I know what the logic is trying to compute.
i.e., let focusedTreeElement = ...