[webkit-reviews] review canceled: [Bug 188728] Various IndexDB tests abandon documents : [Attachment 348031] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has canceled youenn fablet
<youennf at gmail.com>'s request for review:
Bug 188728: Various IndexDB tests abandon documents
https://bugs.webkit.org/show_bug.cgi?id=188728

Attachment 348031: Patch

https://bugs.webkit.org/attachment.cgi?id=348031&action=review




--- Comment #18 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 348031
  --> https://bugs.webkit.org/attachment.cgi?id=348031
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348031&action=review

>> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:372
>> +	return !m_contextStopped && m_outstandingRequestCount;
> 
> Don't we need to wait for outstanding requests to complete (either after
finishing, or being canceled)? I'm worried that allowing IDBCursor's to be GC'd
while things are still happening could corrupt databases.

This needs a new patch after making IDBCursor no longer an ActiveDOMObject