[webkit-reviews] review granted: [Bug 188957] [Attachment Support] [WK2] Images copied from Mail message view paste with the wrong file name in compose : [Attachment 348113] Rebase on trunk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 27 08:36:26 PDT 2018


Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 188957: [Attachment Support] [WK2] Images copied from Mail message view
paste with the wrong file name in compose
https://bugs.webkit.org/show_bug.cgi?id=188957

Attachment 348113: Rebase on trunk

https://bugs.webkit.org/attachment.cgi?id=348113&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 348113
  --> https://bugs.webkit.org/attachment.cgi?id=348113
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=348113&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1334
> +    auto mainResource = adoptNS([[WebResource alloc] initWithData:markupData
URL:[NSURL URLWithString:@"foo.html"] MIMEType:@"text/html"
textEncodingName:@"utf-8" frameName:nil]);
> +    auto pngResource = adoptNS([[WebResource alloc]
initWithData:testImageData() URL:[NSURL URLWithString:@"1.png"]
MIMEType:@"image/png" textEncodingName:nil frameName:nil]);
> +    auto gifResource = adoptNS([[WebResource alloc]
initWithData:testGIFData() URL:[NSURL URLWithString:@"2.gif"]
MIMEType:@"image/gif" textEncodingName:nil frameName:nil]);
> +    auto archive = adoptNS([[WebArchive alloc]
initWithMainResource:mainResource.get() subresources:@[ pngResource.get(),
gifResource.get() ] subframeArchives:@[ ]]);

We should start using ARC for our unit tests.


More information about the webkit-reviews mailing list