[webkit-reviews] review granted: [Bug 188954] [Apple Pay] PaymentRequest.show() should reject when an unsupported ApplePayRequest version is specified : [Attachment 348098] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 188954: [Apple Pay] PaymentRequest.show() should reject when an unsupported
ApplePayRequest version is specified
https://bugs.webkit.org/show_bug.cgi?id=188954

Attachment 348098: Patch

https://bugs.webkit.org/attachment.cgi?id=348098&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 348098
  --> https://bugs.webkit.org/attachment.cgi?id=348098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348098&action=review

> Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp:55
> +	   return Exception { InvalidAccessError, makeString("\"",
String::number(version), "\" is not a supported version.") };

We should not need the String::number here as long as we include the
StringConcatenateNumbers.h header. Doing it with an explicit call to
String::number makes slower, larger code so we shouldn’t do it. I realize now
you are just moving this code, but consider fixing it while moving it.