[webkit-reviews] review granted: [Bug 188874] Function object should convert params to string before throw a parsing error : [Attachment 348075] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 188874: Function object should convert params to string before throw a
parsing error
https://bugs.webkit.org/show_bug.cgi?id=188874

Attachment 348075: Patch

https://bugs.webkit.org/attachment.cgi?id=348075&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 348075
  --> https://bugs.webkit.org/attachment.cgi?id=348075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348075&action=review

> Source/JavaScriptCore/ChangeLog:9
> +	   ToString operation onto the `body` of the Function constructor
should be performed
> +	   before checking syntax correctness of the parameters.

I have no doubt that this is better, but I wonder where these semantics are
defined and tested unambiguously. There must be lots of other cases where the
order of evaluation side effect is visible, and the new test covers just this
one.