[webkit-reviews] review granted: [Bug 188938] Make IDBCursor::m_request a WeakPtr : [Attachment 348060] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 188938: Make IDBCursor::m_request a WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=188938

Attachment 348060: Patch

https://bugs.webkit.org/attachment.cgi?id=348060&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 348060
  --> https://bugs.webkit.org/attachment.cgi?id=348060
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348060&action=review

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:178
> +    if (!m_request)
> +	   return Exception { InvalidStateError };

Can this be reached?  If so it should have a test.  If not, shouldn't it be an
assert?