[webkit-reviews] review granted: [Bug 188939] Fix authentication for clients of WKPageLoaderClient after r234941 : [Attachment 348063] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 24 18:23:51 PDT 2018
youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188939: Fix authentication for clients of WKPageLoaderClient after r234941
https://bugs.webkit.org/show_bug.cgi?id=188939
Attachment 348063: Patch
https://bugs.webkit.org/attachment.cgi?id=348063&action=review
--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 348063
--> https://bugs.webkit.org/attachment.cgi?id=348063
Patch
LGTM.
We should increase our testing of unimplemented callbacks config through API
tests so that our defaults do not change.
In that particular case, that would require launching the http server...
More information about the webkit-reviews
mailing list