[webkit-reviews] review granted: [Bug 188932] Improve unified source generator script logging and error messages : [Attachment 348040] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 188932: Improve unified source generator script logging and error messages
https://bugs.webkit.org/show_bug.cgi?id=188932

Attachment 348040: Patch

https://bugs.webkit.org/attachment.cgi?id=348040&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 348040
  --> https://bugs.webkit.org/attachment.cgi?id=348040
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348040&action=review

> Source/WTF/ChangeLog:8
> +	   * Scripts/generate-unified-source-bundles.rb:

Why isn't this in Tools/Scripts?

> Source/WTF/Scripts/generate-unified-source-bundles.rb:306
> +# Add trailing semicolon since CMake dislikes not having it.

Maybe just # Add trailing semicolon for CMake