[webkit-reviews] review granted: [Bug 188929] Avoid calling setUntrusted in SimulatedMouseEvent : [Attachment 348038] Cleanup

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 188929: Avoid calling setUntrusted in SimulatedMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=188929

Attachment 348038: Cleanup

https://bugs.webkit.org/attachment.cgi?id=348038&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 348038
  --> https://bugs.webkit.org/attachment.cgi?id=348038
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=348038&action=review

> Source/WebCore/ChangeLog:11
> +	   This makes EventTarget::dispatchEventForBindings the only caller of
setUntrusted().

Can some of these Event members variables be const variables after these
changes?

> Source/WebCore/dom/Event.h:146
> +    Event(const AtomicString& type, CanBubble, IsCancelable, IsComposed,
MonotonicTime timestamp, IsTrusted isTrusted = IsTrusted::Yes);

You don't need to name the parameter here.