[webkit-reviews] review granted: [Bug 188926] Using Touch Bar to scrub video on Youtube results in video playback freeze : [Attachment 348035] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 188926: Using Touch Bar to scrub video on Youtube results in video playback
freeze
https://bugs.webkit.org/show_bug.cgi?id=188926

Attachment 348035: Patch

https://bugs.webkit.org/attachment.cgi?id=348035&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 348035
  --> https://bugs.webkit.org/attachment.cgi?id=348035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348035&action=review

> Source/WebCore/ChangeLog:12
> +	   results in a round-trip between `float in -> MediaTime -> float out`
where in != out, we will wait forever for
> +	   time jump observer to fire. Break the cycle by comparing
m_lastSeekTime to the synchronizerTime only after

Nit: ... wait for *the* time jump observer ...