[webkit-reviews] review granted: [Bug 188923] Introduce _WKInspector : [Attachment 348026] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 24 11:37:02 PDT 2018


Brian Burg <bburg at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188923: Introduce _WKInspector
https://bugs.webkit.org/show_bug.cgi?id=188923

Attachment 348026: Patch

https://bugs.webkit.org/attachment.cgi?id=348026&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 348026
  --> https://bugs.webkit.org/attachment.cgi?id=348026
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348026&action=review

r=me, yay!

> Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:135
> +    [[self webView] evaluateJavaScript:[NSString
stringWithFormat:@"console.error(\"%@\");", error] completionHandler:nil];

Nit: self.webView, maybe


More information about the webkit-reviews mailing list