[webkit-reviews] review granted: [Bug 188907] Add new _webViewRequestPointerLock SPI with a completionHandler : [Attachment 347968] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188907: Add new _webViewRequestPointerLock SPI with a completionHandler
https://bugs.webkit.org/show_bug.cgi?id=188907

Attachment 347968: Patch

https://bugs.webkit.org/attachment.cgi?id=347968&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 347968
  --> https://bugs.webkit.org/attachment.cgi?id=347968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347968&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:100
>  - (void)_webViewRequestPointerLock:(WKWebView *)webView
WK_API_AVAILABLE(macosx(10.12.3));

Should we deprecate this?

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:101
> +- (void)_webViewRequestPointerLock:(WKWebView *)webView
completionHandler:(void (^)(BOOL))completionHandler
WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

_webViewDidRequestPointerLock?

> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:1179
> +    if (m_uiDelegate.m_delegateMethods.webViewRequestPointerLock)
> +	   [static_cast<id <WKUIDelegatePrivate>>(delegate)
_webViewRequestPointerLock:m_uiDelegate.m_webView];

I'd early return here and un-indent the rest.