[webkit-reviews] review granted: [Bug 188607] EWS bubbles are being hidden due to lack of space. : [Attachment 347967] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 23 16:11:36 PDT 2018


Daniel Bates <dbates at webkit.org> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 188607: EWS bubbles are being hidden due to lack of space.
https://bugs.webkit.org/show_bug.cgi?id=188607

Attachment 347967: Patch

https://bugs.webkit.org/attachment.cgi?id=347967&action=review




--- Comment #29 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 347967
  --> https://bugs.webkit.org/attachment.cgi?id=347967
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347967&action=review

> Websites/bugs.webkit.org/js/status-bubble.js:35
> +	   iframe.style.width = event.data.width + 'px';

Once we set the style for the frame we can stop the iteration. The version I
wrote in comment 26 did this.


More information about the webkit-reviews mailing list