[webkit-reviews] review granted: [Bug 188898] [iOS] Test editing/undo/replace-text-in-node-preserving-markers-crash.html crashes : [Attachment 347959] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 23 15:41:05 PDT 2018
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 188898: [iOS] Test
editing/undo/replace-text-in-node-preserving-markers-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=188898
Attachment 347959: Patch
https://bugs.webkit.org/attachment.cgi?id=347959&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 347959
--> https://bugs.webkit.org/attachment.cgi?id=347959
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=347959&action=review
> Source/WebCore/dom/DocumentMarker.h:129
> #if PLATFORM(IOS)
I wonder if we really need these #ifdefs. Can we just stub things out on macOS?
More information about the webkit-reviews
mailing list