[webkit-reviews] review granted: [Bug 188828] Spelling dots do not scale with page on iOS; share spelling dot painting code between Mac and iOS : [Attachment 347809] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 23 15:25:40 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 188828: Spelling dots do not scale with page on iOS; share spelling dot
painting code between Mac and iOS
https://bugs.webkit.org/show_bug.cgi?id=188828

Attachment 347809: Patch

https://bugs.webkit.org/attachment.cgi?id=347809&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 347809
  --> https://bugs.webkit.org/attachment.cgi?id=347809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347809&action=review

> Source/WebCore/rendering/RenderThemeCocoa.mm:29
>  #if ENABLE(APPLE_PAY)

Er, why are all these #includes under ENABLE(APPLE_PAY)? I think you'll have to
move out those you need for drawLineForDocumentMarker().


More information about the webkit-reviews mailing list