[webkit-reviews] review granted: [Bug 188901] [CMake] Have checks are not getting set inside CMake properly : [Attachment 347951] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 188901: [CMake] Have checks are not getting set inside CMake properly
https://bugs.webkit.org/show_bug.cgi?id=188901

Attachment 347951: Patch

https://bugs.webkit.org/attachment.cgi?id=347951&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 347951
  --> https://bugs.webkit.org/attachment.cgi?id=347951
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347951&action=review

> PerformanceTests/CMakeLists.txt:5
> +else ()
> +    message(WARNING "MallocBench is not available on this platform")

Isn't this warning message just going to be annoying?

> Source/cmake/WebKitFeatures.cmake:365
> -    SET_AND_EXPOSE_TO_BUILD(${_variable} ${_variable}_value)
> +    SET_AND_EXPOSE_TO_BUILD(${_variable} ${${_variable}_value})

Ouch.