[webkit-reviews] review granted: [Bug 188895] YARR: Need to JIT compile a RegExp before using containsNestedSubpatterns flag : [Attachment 347944] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 23 12:05:15 PDT 2018
Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 188895: YARR: Need to JIT compile a RegExp before using
containsNestedSubpatterns flag
https://bugs.webkit.org/show_bug.cgi?id=188895
Attachment 347944: Patch
https://bugs.webkit.org/attachment.cgi?id=347944&action=review
--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 347944
--> https://bugs.webkit.org/attachment.cgi?id=347944
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=347944&action=review
r=me
> Source/JavaScriptCore/yarr/YarrJIT.cpp:3565
> + codeBlock.setUsesPaternContextBuffer();
nit: "Patern" looks mis-spelled. Maybe fix in a follow up patch since it's not
related to this issue.
More information about the webkit-reviews
mailing list