[webkit-reviews] review denied: [Bug 188878] [iOS] Support the inputmode attribute on contenteditable elements : [Attachment 347898] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 188878: [iOS] Support the inputmode attribute on contenteditable elements
https://bugs.webkit.org/show_bug.cgi?id=188878

Attachment 347898: Patch

https://bugs.webkit.org/attachment.cgi?id=347898&action=review




--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 347898
  --> https://bugs.webkit.org/attachment.cgi?id=347898
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347898&action=review

> Source/WebCore/html/HTMLElement.h:113
> +    const AtomicString& inputMode() const;
> +    void setInputMode(const AtomicString& value);

I don't think it makes much sense for these functions to take & return
AtomicString
since setInputMode does a case-insensitive comparison. Just use String instead.

> LayoutTests/fast/forms/inputmode-attribute.html:29
> +shouldBe('textarea.inputMode = "tel"; textarea.inputMode', '"tel"');
> +shouldBe('textarea.getAttribute("inputmode")', '"tel"');
> +shouldBe('textarea.setAttribute("inputmode", "tel"); textarea.inputMode',
'"tel"');
> +shouldBe('editor.inputMode = "url"; editor.inputMode', '"url"');

We need to test every type on every element type.
r- because of this reduces the test coverage and doesn't provide adequate
amount of testing for content editable element support.