[webkit-reviews] review granted: [Bug 188867] [WTF] Add generic implementation for Memory querying : [Attachment 347875] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 18:47:47 PDT 2018


Fujii Hironori <Hironori.Fujii at sony.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 188867: [WTF] Add generic implementation for Memory querying
https://bugs.webkit.org/show_bug.cgi?id=188867

Attachment 347875: Patch

https://bugs.webkit.org/attachment.cgi?id=347875&action=review




--- Comment #4 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 347875
  --> https://bugs.webkit.org/attachment.cgi?id=347875
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347875&action=review

> Source/WTF/wtf/PlatformJSCOnly.cmake:59
> +elseif (CMAKE_SYSTEM_NAME MATCHES ".*Linux")

You don't need '.*'.

https://github.com/WebKit/webkit/blob/master/Source/cmake/OptionsGTK.cmake#L113

> if (CMAKE_SYSTEM_NAME MATCHES "Linux")

BTW, the following code just use STREQUAL.

https://github.com/WebKit/webkit/blob/master/Source/cmake/OptionsCommon.cmake#L
22

> ${CMAKE_SYSTEM_NAME} STREQUAL "Linux"

How does the variable CMAKE_SYSTEM_NAME look like? Can it be "FooBar Linux"?


More information about the webkit-reviews mailing list