[webkit-reviews] review granted: [Bug 188866] [MediaStream] Store video preset sizes in a map : [Attachment 347855] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 16:00:38 PDT 2018


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 188866: [MediaStream] Store video preset sizes in a map
https://bugs.webkit.org/show_bug.cgi?id=188866

Attachment 347855: Patch

https://bugs.webkit.org/attachment.cgi?id=347855&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 347855
  --> https://bugs.webkit.org/attachment.cgi?id=347855
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347855&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:279
> +    VideoPresetMap m_supportedPresets;

I would keep m_supportedPresets in AVVideoCaptureSource for now since this is
the sole user.


More information about the webkit-reviews mailing list