[webkit-reviews] review granted: [Bug 181294] [Attachment Support] Support dragging attachment elements out as files on macOS : [Attachment 347811] Fix OpenSource macOS builds

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 181294: [Attachment Support] Support dragging attachment elements out as
files on macOS
https://bugs.webkit.org/show_bug.cgi?id=181294

Attachment 347811: Fix OpenSource macOS builds

https://bugs.webkit.org/attachment.cgi?id=347811&action=review




--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347811
  --> https://bugs.webkit.org/attachment.cgi?id=347811
Fix OpenSource macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=347811&action=review

> Source/WebCore/editing/cocoa/EditorCocoa.mm:173
> +    // On macOS, we currently write the attachment as a web archive; we
can't do the same for iOS and remove the platform guard below

s/below/above/?

> Source/WebKit/UIProcess/API/mac/WKView.mm:1096
> +- (NSString
*)filePromiseProvider:(NSFilePromiseProvider*)filePromiseProvider
fileNameForType:(NSString *)fileType

Stars on the wrong side

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3925
> +    return [NSError errorWithDomain:WKErrorDomain code:WKErrorUnknown
userInfo:nil];
> +#else
> +    return [NSError errorWithDomain:@"WebKitErrorDomain" code:1
userInfo:nil];

This is weird. Have we ever done this before?

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:4003
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200

Do we still build back to 10.11? What's up with all of this. Should/can it be a
specific HAVE() or USE() instead?