[webkit-reviews] review granted: [Bug 188764] WKNavigationDelegate needs to allow clients to specify a custom blocked plug-in message : [Attachment 347816] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Jeff Miller
<jeffm at apple.com>'s request for review:
Bug 188764: WKNavigationDelegate needs to allow clients to specify a custom
blocked plug-in message
https://bugs.webkit.org/show_bug.cgi?id=188764

Attachment 347816: Patch

https://bugs.webkit.org/attachment.cgi?id=347816&action=review




--- Comment #17 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 347816
  --> https://bugs.webkit.org/attachment.cgi?id=347816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347816&action=review

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:366
> +	   completionHandler(currentPluginLoadPolicy, String());

{ }

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:373
> +	   [(id <WKNavigationDelegatePrivate>)navigationDelegate
_webView:m_navigationState.m_webView
decidePolicyForPluginLoadWithCurrentPolicy:wkPluginModuleLoadPolicy(currentPlug
inLoadPolicy) pluginInfo:wrapper(pluginInformation)
completionHandler:^(_WKPluginModuleLoadPolicy policy, NSString
*unavailabilityDescription) {

I'm surprised this compiles without using BlockPtr because CompletionHandler is
not copyable and blocks are.