[webkit-reviews] review granted: [Bug 188803] Web Inspector: cannot delete multiple event breakpoints by repeatedly hitting delete : [Attachment 347771] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 10:29:08 PDT 2018


Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 188803: Web Inspector: cannot delete multiple event breakpoints by
repeatedly hitting delete
https://bugs.webkit.org/show_bug.cgi?id=188803

Attachment 347771: Patch

https://bugs.webkit.org/attachment.cgi?id=347771&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 347771
  --> https://bugs.webkit.org/attachment.cgi?id=347771
Patch

We removed and re-appended the tree whenever a breakpoint was deleted! Looks
like copypasta from the broken code I added for DOM breakpoints. :(


More information about the webkit-reviews mailing list