[webkit-reviews] review granted: [Bug 188693] [CoordGraphics] Switch to Nicosia::CompositionLayer state tracking : [Attachment 347627] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 188693: [CoordGraphics] Switch to Nicosia::CompositionLayer state tracking
https://bugs.webkit.org/show_bug.cgi?id=188693

Attachment 347627: Patch

https://bugs.webkit.org/attachment.cgi?id=347627&action=review




--- Comment #21 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 347627
  --> https://bugs.webkit.org/attachment.cgi?id=347627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347627&action=review

I would file bugs for all the FIXMEs to ensure we don't forget about it.

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cp
p:453
> +    m_nicosia.contentLayer = contentLayer;

Should we do this inside the previous if?

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cp
p:831
> +    } else {
> +	   if (m_nicosia.backingStore) {

else if