[webkit-reviews] review granted: [Bug 188826] Change Selection modification to not snap the grabber when selecting above or below the selection anchor : [Attachment 347724] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 188826: Change Selection modification to not snap the grabber when
selecting above or below the selection anchor
https://bugs.webkit.org/show_bug.cgi?id=188826

Attachment 347724: Patch

https://bugs.webkit.org/attachment.cgi?id=347724&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347724
  --> https://bugs.webkit.org/attachment.cgi?id=347724
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347724&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1224
> +    IntPoint adjustedPoint(pointInRootViewCoordinates.x(),
pointInRootViewCoordinates.y());

Why not just `IntPoint adjustedPoint = pointInRootViewCoordinates`?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1228
> +	   int startY = caret.y() + caret.height() / 2;

We have center(), maybe use that?