[webkit-reviews] review granted: [Bug 183621] Add support for the `inputmode` attribute : [Attachment 347720] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 183621: Add support for the `inputmode` attribute
https://bugs.webkit.org/show_bug.cgi?id=183621

Attachment 347720: Patch

https://bugs.webkit.org/attachment.cgi?id=347720&action=review




--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347720
  --> https://bugs.webkit.org/attachment.cgi?id=347720
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347720&action=review

> Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:192
> +    NSArray *inputModes = @[ @"", @"text", @"tel", @"url", @"email",
@"numeric", @"decimal", @"search" ];

Could create this from the dictionary with -allKeys. Except "" I guess... I
dunno.

> Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:203
> +    NSArray *inputTypesWithKeyboard = @[ @"text", @"password", @"search",
@"email", @"tel", @"number", @"url" ];

Could create this from the dictionary with -allKeys